fix(ui): exclude display name from required-field validation in tool form by Nayana-R-Gowda · Pull Request #3464 · IBM/mcp-context-forge

Nayana-R-Gowda · 2026-03-04T13:13:10Z

Signed-off-by: NAYANA.R nayana.r7813@gmail.com
closes #3433

💡 Fix Description

ixed validation selector in admin.js so displayName is no longer treated like the required technical name field.

🧪 Verification

Check	Command	Status
Lint suite	`make lint`	pass
Unit tests	`make test`	pass

📐 MCP Compliance (if relevant)

Matches current MCP spec
No breaking change to MCP clients

✅ Checklist

Code formatted (make black isort pre-commit)
No secrets/credentials committed

msureshkumar88

Code Review Summary for PR #3464

Issue: #3433 - Unable to create a tool without a display name

Changes: Modified admin.js:16625-16627 to fix form validation selector

✅ Fix Validation

The PR correctly addresses the reported bug:

Root Cause: The wildcard selector input[name*="name"] was matching ALL fields containing "name", including the optional displayName field
Solution: Changed to exact attribute matching: input[name="name"], input[name="customName"], input[name="custom_name"]
Result: Optional displayName fields are no longer incorrectly validated as required

📊 Review Findings

1 issues identified:

Medium Severity: Missing test coverage for the validation exclusion fix

✅ Strengths

Minimal, surgical fix that directly addresses the bug
Preserves validation for actual required name fields
Handles multiple naming conventions (name, customName, custom_name)
Clear inline comment explaining the change

🔍 Key Recommendations

Add automated tests to prevent regression (most important)

crivetimihai · 2026-03-05T13:48:27Z

Thanks @Nayana-R-Gowda — correct fix for #3433. Narrowing the querySelector to only target technical name fields is the right approach. LGTM.

Nayana-R-Gowda · 2026-03-06T07:14:26Z

The validation selector was updated to target only the actual technical name fields (name, customName, custom_name) so that optional displayName fields are no longer validated as required.

…form The name-field validation selector used a wildcard (input[name*="name"]) that also matched displayName and display_name inputs, making the optional display-name field effectively required. Switch to explicit selectors for technical name fields only, and filter out hidden inputs so edit-form hidden name fields are also skipped. Closes #3433 Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

Cover the name-field selection logic introduced in the previous commit: - visible name and customName inputs are validated on blur - displayName and display_name inputs are excluded - hidden name inputs (edit forms) are excluded - error styling is applied/cleared correctly - combined form scenarios (create + edit layouts) Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>

crivetimihai

Reviewed and verified — the fix is correct and well-targeted.

Code review notes:

The old wildcard selector input[name*="name"] matched displayName and display_name fields, making the optional display name effectively required. The new explicit selectors (input[name="name"], input[name="customName"], input[name="custom_name"]) correctly target only technical name fields.
The hidden-input filter correctly excludes the name="name" hidden field in edit forms.
No security concerns — backend validate_display_name() validators in schemas.py still sanitize display names server-side.
No performance concerns.

Changes made during review:

Rebased onto main and squashed 5 commits (2 feature + 3 merge) into 1 clean commit, preserving original author.
Added 9 unit tests in tests/js/admin-form-validation.test.js covering all branches: visible name validated, customName validated, displayName excluded, display_name excluded, hidden name excluded, error styling applied/cleared, and combined create/edit form scenarios.
Verified E2E via Playwright: tool creation succeeds with empty display name, tool appears in the table.

All 831 JS tests pass.

crivetimihai · 2026-03-10T11:11:04Z

Maintainer review changes

Rebased onto main, squashed 5 commits into 1 clean commit (preserving original author), and added differential test coverage:

Commits after rebase

fix(ui): exclude display name from required-field validation in tool form — original fix by @Nayana-R-Gowda
test(ui): add setupFormValidation tests for display name exclusion — 9 unit tests covering all selector/filter branches

Tests added (`tests/js/admin-form-validation.test.js`)

Test	Validates
visible `input[name="name"]`	validated on blur
`input[name="customName"]`	validated on blur
`input[name="displayName"]`	excluded from validation
`input[name="display_name"]`	excluded from validation
hidden `input[name="name"]`	excluded from validation
valid name clears styling	error classes removed
invalid name shows styling	`border-red-500` applied
combined name + displayName form	only name validated
edit form layout	hidden name excluded, customName validated, displayName excluded

E2E verification

Verified via Playwright: created a tool with Display Name left empty — form submitted successfully, tool appeared in the table.

Solved

…form (IBM#3464) * fix(ui): exclude display name from required-field validation in tool form The name-field validation selector used a wildcard (input[name*="name"]) that also matched displayName and display_name inputs, making the optional display-name field effectively required. Switch to explicit selectors for technical name fields only, and filter out hidden inputs so edit-form hidden name fields are also skipped. Closes IBM#3433 Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * test(ui): add setupFormValidation tests for display name exclusion Cover the name-field selection logic introduced in the previous commit: - visible name and customName inputs are validated on blur - displayName and display_name inputs are excluded - hidden name inputs (edit forms) are excluded - error styling is applied/cleared correctly - combined form scenarios (create + edit layouts) Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Dumitru C <canteadumitru@gmail.com>

…form (#3464) * fix(ui): exclude display name from required-field validation in tool form The name-field validation selector used a wildcard (input[name*="name"]) that also matched displayName and display_name inputs, making the optional display-name field effectively required. Switch to explicit selectors for technical name fields only, and filter out hidden inputs so edit-form hidden name fields are also skipped. Closes #3433 Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * test(ui): add setupFormValidation tests for display name exclusion Cover the name-field selection logic introduced in the previous commit: - visible name and customName inputs are validated on blur - displayName and display_name inputs are excluded - hidden name inputs (edit forms) are excluded - error styling is applied/cleared correctly - combined form scenarios (create + edit layouts) Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>

…form (#3464) * fix(ui): exclude display name from required-field validation in tool form The name-field validation selector used a wildcard (input[name*="name"]) that also matched displayName and display_name inputs, making the optional display-name field effectively required. Switch to explicit selectors for technical name fields only, and filter out hidden inputs so edit-form hidden name fields are also skipped. Closes #3433 Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> * test(ui): add setupFormValidation tests for display name exclusion Cover the name-field selection logic introduced in the previous commit: - visible name and customName inputs are validated on blur - displayName and display_name inputs are excluded - hidden name inputs (edit forms) are excluded - error styling is applied/cleared correctly - combined form scenarios (create + edit layouts) Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: NAYANA.R <nayana.r7813@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Yosief Eyob <yosiefogbazion@gmail.com>

Nayana-R-Gowda requested a review from crivetimihai as a code owner March 4, 2026 13:13

Nayana-R-Gowda requested review from kevalmahajan and madhav165 March 4, 2026 13:44

msureshkumar88 self-requested a review March 4, 2026 15:24

msureshkumar88 previously requested changes Mar 5, 2026

View reviewed changes

crivetimihai changed the title ~~This prevents the admin UI from blocking tool creation when the optional Display Name is left empty~~ fix(ui): exclude display name from required-field validation in tool form Mar 5, 2026

crivetimihai added bug Something isn't working ui User Interface SHOULD P2: Important but not vital; high-value items that are not crucial for the immediate release labels Mar 5, 2026

crivetimihai added this to the Release 1.0.0-RC2 milestone Mar 5, 2026

crivetimihai modified the milestones: Release 1.0.0-RC2, Release 1.0.0 Mar 7, 2026

crivetimihai self-assigned this Mar 7, 2026

Nayana-R-Gowda and others added 2 commits March 10, 2026 11:04

crivetimihai force-pushed the bug/ui-tool-creation-requires-display-name branch from 47dd363 to 92f9c9a Compare March 10, 2026 11:10

crivetimihai approved these changes Mar 10, 2026

View reviewed changes

crivetimihai merged commit 3c970d5 into main Mar 10, 2026
44 checks passed

crivetimihai deleted the bug/ui-tool-creation-requires-display-name branch March 10, 2026 11:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): exclude display name from required-field validation in tool form#3464

fix(ui): exclude display name from required-field validation in tool form#3464
crivetimihai merged 2 commits intomainfrom
bug/ui-tool-creation-requires-display-name

Nayana-R-Gowda commented Mar 4, 2026 •

edited

Loading

Uh oh!

msureshkumar88 left a comment •

edited

Loading

Uh oh!

crivetimihai commented Mar 5, 2026

Uh oh!

Nayana-R-Gowda commented Mar 6, 2026

Uh oh!

crivetimihai left a comment

Uh oh!

crivetimihai commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Nayana-R-Gowda commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Fix Description

🧪 Verification

📐 MCP Compliance (if relevant)

✅ Checklist

Uh oh!

msureshkumar88 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Summary for PR #3464

✅ Fix Validation

📊 Review Findings

✅ Strengths

🔍 Key Recommendations

Uh oh!

crivetimihai commented Mar 5, 2026

Uh oh!

Nayana-R-Gowda commented Mar 6, 2026

Uh oh!

crivetimihai left a comment

Choose a reason for hiding this comment

Uh oh!

crivetimihai commented Mar 10, 2026

Maintainer review changes

Commits after rebase

Tests added (tests/js/admin-form-validation.test.js)

E2E verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nayana-R-Gowda commented Mar 4, 2026 •

edited

Loading

msureshkumar88 left a comment •

edited

Loading

Tests added (`tests/js/admin-form-validation.test.js`)